-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientReconnectTest flaky test fix #1053
Conversation
This pr should fix 4.2.0 fail, I did not really understand why 4.0.0 test failed though. 🤔 https://github.com/hazelcast/client-compatibility-suites/runs/3646558223?check_suite_focus=true @mdumandag Can you see why? (we may need version 4.0.2 check for this test as well) |
I think with this change we don't need the version check anymore and can delete the version check for I think 4.0.0 fail is due to connection close too, but since we don't close socket on error prior to 4.0.2 it hangs 120 seconds and times out. |
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
- Coverage 92.58% 92.31% -0.27%
==========================================
Files 432 432
Lines 16730 16730
Branches 1037 1037
==========================================
- Hits 15489 15444 -45
- Misses 976 1018 +42
- Partials 265 268 +3
Continue to review full report at Codecov.
|
* Add client version check * Add version check for all reconnect tests * Fix flaky ClientReconnectTest * Adjust comment * Delete version check * Delete unused import
Fix for https://github.com/hazelcast/client-compatibility-suites/actions/runs/1251558570
I explained the fail in comments