Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientReconnectTest flaky test fix #1053

Merged
merged 7 commits into from
Sep 20, 2021
Merged

ClientReconnectTest flaky test fix #1053

merged 7 commits into from
Sep 20, 2021

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Sep 20, 2021

@srknzl
Copy link
Member Author

srknzl commented Sep 20, 2021

This pr should fix 4.2.0 fail, I did not really understand why 4.0.0 test failed though. 🤔 https://github.com/hazelcast/client-compatibility-suites/runs/3646558223?check_suite_focus=true

@mdumandag Can you see why? (we may need version 4.0.2 check for this test as well)

@srknzl
Copy link
Member Author

srknzl commented Sep 20, 2021

I think with this change we don't need the version check anymore and can delete the version check for create proxy while member is down, member comes back. also member restarts, while map.put in progress 2 should pass since we wait for connections to be closed.

I think 4.0.0 fail is due to connection close too, but since we don't close socket on error prior to 4.0.2 it hangs 120 seconds and times out.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1053 (ce71bfe) into master (0b44a79) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   92.58%   92.31%   -0.27%     
==========================================
  Files         432      432              
  Lines       16730    16730              
  Branches     1037     1037              
==========================================
- Hits        15489    15444      -45     
- Misses        976     1018      +42     
- Partials      265      268       +3     
Impacted Files Coverage Δ
src/network/ConnectionManager.ts 81.12% <0.00%> (-6.18%) ⬇️
src/config/ConfigBuilder.ts 93.95% <0.00%> (-2.85%) ⬇️
src/protocol/ErrorFactory.ts 64.23% <0.00%> (-1.46%) ⬇️
src/core/HazelcastError.ts 65.36% <0.00%> (-1.12%) ⬇️
src/invocation/ClusterService.ts 93.61% <0.00%> (-0.71%) ⬇️
src/util/Util.ts 87.74% <0.00%> (-0.65%) ⬇️
src/invocation/InvocationService.ts 95.13% <0.00%> (-0.38%) ⬇️
src/nearcache/RepairingTask.ts 95.58% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b44a79...ce71bfe. Read the comment docs.

@srknzl srknzl merged commit 5a0f1b9 into hazelcast:master Sep 20, 2021
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
* Add client version check

* Add version check for all reconnect tests

* Fix flaky ClientReconnectTest

* Adjust comment

* Delete version check

* Delete unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants