Add filter argument to ringbuffer readMany() method and a test for it API-1294 #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1414 +/- ##
==========================================
- Coverage 93.28% 93.27% -0.01%
==========================================
Files 463 464 +1
Lines 16347 16386 +39
Branches 1329 1333 +4
==========================================
+ Hits 15249 15284 +35
- Misses 801 803 +2
- Partials 297 299 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srknzl
changed the title
srknzl
requested changes
Nov 7, 2022
test/integration/backward_compatible/parallel/ringbuffer/RingbufferProxyTest.js
Outdated
Show resolved
Hide resolved
srknzl
approved these changes
Nov 16, 2022
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Nov 23, 2022
… API-1294 (hazelcast#1414) * add filter argument to ringbuffer readMany() method and a test for it * fix some typos
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
… API-1294 (hazelcast#1414) * add filter argument to ringbuffer readMany() method and a test for it * fix some typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.