Revert "Change logic around closing connections and writers API-1283 (#1417)" #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…azelcast#1417)" This reverts commit 2d0b397.
mdumandag
approved these changes
Dec 5, 2022
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 466 466
Lines 16623 16623
Branches 1351 1351
=======================================
Hits 15488 15488
Misses 832 832
Partials 303 303 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Merged with one approval as this is just a revert |
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 7, 2022
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
srknzl
added a commit
to fatihozer0/hazelcast-nodejs-client
that referenced
this pull request
Mar 24, 2023
…azelcast#1417)" (hazelcast#1430) This reverts commit 2d0b397.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change should have been merged after 5.2.0 release. Reverting until then.
This reverts commit 2d0b397.