Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logging check #1604

Closed
wants to merge 1 commit into from
Closed

Remove debug logging check #1604

wants to merge 1 commit into from

Conversation

Siecje
Copy link
Contributor

@Siecje Siecje commented Jun 24, 2024

Unless this is hyper optimization this check done inside the log. https://github.com/python/cpython/blob/3.12/Lib/logging/__init__.py#L1517

Unless this is hyper optimization this check done inside the log.
https://github.com/python/cpython/blob/3.12/Lib/logging/__init__.py#L1517
@dlech
Copy link
Collaborator

dlech commented Jun 24, 2024

These were found to have a measurable difference in performance when profiling. (Mentioned in #1376)

So I would need to see hard evidence to the contrary before making these changes.

@Siecje
Copy link
Contributor Author

Siecje commented Jun 25, 2024

Should this be done in other files?

@Siecje Siecje closed this Jun 25, 2024
@dlech
Copy link
Collaborator

dlech commented Jun 25, 2024

Only if profiling shows a measured improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants