Fix when characteristic updates value faster than asyncio schedule. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superfashi
changed the title
superfashi
changed the title
hbldh
added
asyncio
|
This looks like a good fix to me. We should probably make the same change for descriptor values. |
hbldh
approved these changes
Jul 2, 2020
| @@ -318,6 +318,7 @@ def peripheral_didUpdateValueForCharacteristic_error_( | |||
| self.did_update_value_for_characteristic, | |||
| peripheral, | |||
| characteristic, | |||
| characteristic.value(), | |||
There was a problem hiding this comment.
I seem to remember that I had to do something equivalent to copy.copy(characteristic.value()) when I handled a similar situation. Are you sure that this is sufficient?
What I got returned then was a class instance of data class, whereas this is a bytes object. That is a clear difference...
There was a problem hiding this comment.
When I tested this it's a bytes object so this should be sufficient. Do you have any documents on the behavior of this for pyobjc?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems running with my code, but there could potentially be other places that is experiencing a similar situation.