Cleanups #324
Merged
Cleanups #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
force-pushed
the
cleanups
branch
2 times, most recently
from
6eaead5
to
c1bae18
Compare
|
We should be careful with the "Remove unused imports" commit. It it probably removes some stuff that is used in later pull requests like |
|
Very good. We wait with this one until #328 is merged. |
hbldh
added
Backend: pythonnet
The `BLEDevice` class is already defined for all backends in `bleak/backends/device.py`. It looks like an extra copy is left over in the CoreBluetooth that can be removed.
The arguments listed were probably for a older version of the function. This also fixes an unused import warning from flake8 since IAsyncOperation is now used for the type hint.
This fixes flake8 E722. Using bare except will also catch BaseException which would suppress things like KeyboardInterrupt.
This fixes flake8 E713.
black randomly decided that it wants commas here now
E203: black adds spaces around `:` in some cases E501: black allows long lines in some cases W503: black disagrees with flake8 on line breaks before binary operators
As reported by flake8 F401.
As reported by flake8 F841.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some various code cleanups. Mostly suggested by flake8.