Removed separate implementation of global discover method. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a more informative error message for unsupported platforms. Previously the if block would fall through which would likely cause `AttributeError`s or `ImportError`s.
The "old" `discover()` method was largely duplicating the code from `BleackScanner.discover()`, with the exception of the Mac backend which looked like it might not even work correctly and ignored kwargs. This removes the `discover()` method from the documentation and removes the separate implementation. The name is still kept and made as a synonym for for `BleakScanner.discover` so that we don't completely break existing code that might be using it.
dlech
force-pushed
the
discovery-refactor
branch
from
0517ef2
to
d129ff8
Compare
…ed first. This adds an `from BleakBridge import Bridge` to all files that use winrt bindings. This ensures that imports work no matter which module is imported first.
dlech
force-pushed
the
discovery-refactor
branch
from
d129ff8
to
7477722
Compare
|
Yes. I meant to do this when I implemented the scanner, but I decided to wait until I was sure it was stable. Then I forgot it. Well done! |
dlech
added a commit
that referenced
this pull request
Dec 11, 2020
Use `BleakScanner.discover` instead of "old" `discover`. (follow up of #387)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "old"
discover()method was largely duplicating the code fromBleackScanner.discover(), with the exception of the Mac backend which looked like it might not even work correctly and ignored kwargs.Rather than trying to maintain two separate implementations that are supposed to dot he same thing, this removes the
discover()method from the documentation and removes the separate implementation. The name is still kept and made as a synonym for forBleakScanner.discoverso that we don't completely break existing code that might be using it.