Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service throws error if postcode cannot be found #40

Closed
SBRitter opened this issue Aug 3, 2016 · 1 comment · Fixed by #44
Closed

Service throws error if postcode cannot be found #40

SBRitter opened this issue Aug 3, 2016 · 1 comment · Fixed by #44
Assignees
@SBRitter
Labels
bug org-launch

Comments

@SBRitter
Copy link
Contributor

SBRitter commented Aug 3, 2016 •
edited by fsteeg
Loading

An error is thrown if the postcode cannot be found in JSON coming from Nominatim.

Sample error output:

[error] play - Cannot invoke the action, eventually got an error: org.json.JSONException: JSONObject["postcode"] not found.
[error] application - 

! @711781k9f - Internal server error, for (GET) [/geodata/long/J%205/Mannheim/DE] ->

play.api.Application$$anon$1: Execution exception[[JSONException: JSONObject["postcode"] not found.]]
    at play.api.Application$class.handleError(Application.scala:296) ~[play_2.11-2.3.4.jar:2.3.4]
    at play.api.DefaultApplication.handleError(Application.scala:402) [play_2.11-2.3.4.jar:2.3.4]
    at play.core.server.netty.PlayDefaultUpstreamHandler$$anonfun$3$$anonfun$applyOrElse$4.apply(PlayDefaultUpstreamHandler.scala:320) [play_2.11-2.3.4.jar:2.3.4]
    at play.core.server.netty.PlayDefaultUpstreamHandler$$anonfun$3$$anonfun$applyOrElse$4.apply(PlayDefaultUpstreamHandler.scala:320) [play_2.11-2.3.4.jar:2.3.4]
    at scala.Option.map(Option.scala:145) [scala-library-2.11.1.jar:na]
Caused by: org.json.JSONException: JSONObject["postcode"] not found.
    at org.json.JSONObject.get(JSONObject.java:476) ~[json-20141113.jar:na]
    at controllers.geo.NominatimQuery.getPostcode(NominatimQuery.java:47) ~[classes/:na]
    at controllers.geo.NominatimQuery.createGeoNode(NominatimQuery.java:59) ~[classes/:na]
    at controllers.geo.GeoInformator.getFirstGeoNode(GeoInformator.java:95) ~[classes/:na]
    at controllers.geo.GeoInformator.getLatLong(GeoInformator.java:82) ~[classes/:na]
@SBRitter SBRitter added the bug label Aug 3, 2016
@SBRitter SBRitter self-assigned this Aug 3, 2016
@fsteeg fsteeg added the ready label Aug 25, 2016
@fsteeg fsteeg self-assigned this Aug 25, 2016
@fsteeg fsteeg added working and removed ready labels Aug 25, 2016
fsteeg added a commit that referenced this issue Aug 26, 2016
@fsteeg
Handle missing JSON element where it's accessed (#40)
48d7b22
@fsteeg
Copy link
Member

fsteeg commented Aug 26, 2016

Deployed to staging: http://quaoar1.hbz-nrw.de:7401/geodata/long/J%205/Mannheim/DE

@fsteeg fsteeg added review and removed working labels Aug 26, 2016
@fsteeg fsteeg assigned SBRitter and unassigned fsteeg Aug 26, 2016
@fsteeg fsteeg mentioned this issue Aug 26, 2016
Closed
fsteeg added a commit that referenced this issue Aug 29, 2016
@fsteeg
Return internal server error status if result is null (#40)
f5f8576 
To distinguish processing errors from actual `not found` errors
due to wrong paths when calling from a client.

See also hbz/lobid-organisations#77
SBRitter pushed a commit that referenced this issue Sep 8, 2016
@fsteeg @SBRitter
Handle missing JSON element where it's accessed (#40)
61733c5
@SBRitter SBRitter mentioned this issue Sep 8, 2016
Merged
@SBRitter SBRitter removed the review label Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SBRitter SBRitter

Labels
bug org-launch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle missing JSON element where it's accessed hbz/geodata
2 participants
@fsteeg @SBRitter