Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error on invalid queries #156

Closed
2 tasks done
fsteeg opened this issue Sep 20, 2018 · 4 comments · Fixed by #157
Closed
2 tasks done

Handle error on invalid queries #156

fsteeg opened this issue Sep 20, 2018 · 4 comments · Fixed by #157
Labels
bug

Comments

@fsteeg
Copy link
Member

fsteeg commented Sep 20, 2018 •
edited
Loading

See http://lobid.org/gnd/search?q=%2B%2Btest (enter ++test in the search field)

  • Don't show error screen to user
  • Don't pollute log with stack traces
@fsteeg fsteeg self-assigned this Sep 20, 2018
fsteeg added a commit that referenced this issue Sep 20, 2018
@fsteeg
Handle errors on invalid queries
aa879bc 
See #156
@fsteeg fsteeg mentioned this issue Sep 20, 2018
Merged
@dr0i dr0i added review and removed working labels Sep 20, 2018
@fsteeg
Copy link
Member Author

fsteeg commented Sep 20, 2018

Deployed to stage: http://stage.lobid.org/gnd/search?q=%2B%2Btest

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Sep 20, 2018
@acka47
Copy link
Contributor

acka47 commented Sep 20, 2018

+1

@acka47 acka47 removed their assignment Sep 20, 2018
fsteeg added a commit that referenced this issue Sep 20, 2018
@fsteeg
Return proper error code, embed message in error template
f92d5c5 
See #156
fsteeg added a commit that referenced this issue Sep 20, 2018
@fsteeg
Return proper error code, embed message in error template
68ce911 
See #156
@fsteeg
Copy link
Member Author

fsteeg commented Sep 20, 2018

Redeployed to stage: http://stage.lobid.org/gnd/search?q=%2B%2Btest

@acka47
Copy link
Contributor

acka47 commented Sep 20, 2018

+1

@acka47 acka47 removed their assignment Sep 20, 2018
fsteeg added a commit that referenced this issue Sep 21, 2018
@fsteeg
Merge branch '156-errors' of https://github.com/hbz/lobid-gnd
f9f28d6 
Resolves #156

See http://lobid.org/gnd/search?q=%2B%2Btest
@dr0i dr0i removed the review label Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle errors on invalid queries hbz/lobid-gnd
3 participants
@fsteeg @acka47 @dr0i