Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more subfields to musical work information #556

Closed
acka47 opened this issue Aug 29, 2017 · 5 comments
Closed

Add more subfields to musical work information #556

acka47 opened this issue Aug 29, 2017 · 5 comments

Comments

@acka47
Copy link
Contributor

acka47 commented Aug 29, 2017

As written in #516 (comment):

people will also want the information from 303, subfields m, n and r.

lobid/lodmill#784 (comment) has the cataloging help for 303. Here is the list of the subfields to add and which RDA properties to use:

I think this should suffice for now.

@ChristophEwertowski
Copy link
Contributor

If it's still relevant it should be tackled after lobid/lodmill#784 is solved.

@ChristophEwertowski
Copy link
Contributor

Deployed to test. See hasMediumOfPerformance in exampleOfWork in HT018853619 (test, json) or in containsExampleOfWork in HT018857620 (test, json). For hasMusicalKey or hasNumericDesignationOfMusicalWork also see HT018857620 (test, json).
Subfields u und p are already covered.

@acka47
Copy link
Contributor Author

acka47 commented Jun 18, 2018

This looks good but I think we should use other labels in the JSON than the ones from RDA. For one, we only have very few properties where we use the "hasX" structure and also the keyes are quite long. Here are my suggestions:

ChristophEwertowski added a commit that referenced this issue Jun 18, 2018
ChristophEwertowski added a commit that referenced this issue Jun 18, 2018
Not all containsExampleOfWork / exampleOfWork contain/are
musical works.

See #556
@ChristophEwertowski
Copy link
Contributor

Deployed to test, see http://test.lobid.org/resources/HT018857620.json.

@acka47
Copy link
Contributor Author

acka47 commented Jun 19, 2018

+1

@acka47 acka47 removed their assignment Jun 19, 2018
@dr0i dr0i added deploy and removed review labels Jun 22, 2018
@dr0i dr0i closed this as completed in #849 Jun 22, 2018
@dr0i dr0i removed the deploy label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants