-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove birthDate from creator and contributor. #244
Comments
We will do this. We chose this form as we thought that it would look like this in the Aleph OPAC but it doesn't. @dr0i I guess we build the strings the same way for subjects and creators/contributors. Obviously, we have to change this as we don't want the birth/death year removed from the subject labels. See #145. |
We were told that it looks kind of rude to present the birth date of all ladies and gentlemen to everyone. We chose to present it only to the library staff (useful for individualisation) but not to the end user. Thank you for solving this! |
Cheez. Note: we assume that rudeness is kinda relative: |
Don't remove this data from persons as subjects, though. See hbz/lobid#244. - adjust tests
Deployed to staging. |
+1 |
+1 |
Deployed to production, closing. |
This should have give me the hint - it's about presenting , not so much about the underlying data. This should be an issue of the frontend, especially when considering the ridiculously amount of work and implementation of logik when doing e.g. lobid/lodmill#742. |
I think it is better to not include birth dates into 'preferredName'. I think also that it was a mistake to do so in first run. There are potentially many front ends but only one lobid. One work hour at lobid saves n*work hours at the clients. |
Maybe , maybe not. E.g. you may miss birth dates when facetting. Point is, the data is in part concatenated , see e.g. lobid/lodmill#742, doing frontends job. Would be better to have multiple fields (like you said at the beginning of the ticket) and let the frontends doing whatever they want. |
I'd suggest to remove the comma separated birth date from preferredName of gnd-authorities. It would be much better to have the birthdate in an extra triple like provided by dnb.
http://d-nb.info/gnd/134268857 http://d-nb.info/standards/elementset/gnd#preferredName "..., 1953-"^^http://www.w3.org/2001/XMLSchema#string .
Example:
http://lobid.org/resource/HT018728844/about
The text was updated successfully, but these errors were encountered: