Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove birthDate from creator and contributor. #244

Closed
jschnasse opened this issue Sep 29, 2015 · 10 comments
Closed

Remove birthDate from creator and contributor. #244

jschnasse opened this issue Sep 29, 2015 · 10 comments
Assignees

Comments

@jschnasse
Copy link

I'd suggest to remove the comma separated birth date from preferredName of gnd-authorities. It would be much better to have the birthdate in an extra triple like provided by dnb.

http://d-nb.info/gnd/134268857 http://d-nb.info/standards/elementset/gnd#preferredName "..., 1953-"^^http://www.w3.org/2001/XMLSchema#string .

Example:
http://lobid.org/resource/HT018728844/about

@acka47
Copy link
Contributor

acka47 commented Sep 30, 2015

We will do this. We chose this form as we thought that it would look like this in the Aleph OPAC but it doesn't.

@dr0i I guess we build the strings the same way for subjects and creators/contributors. Obviously, we have to change this as we don't want the birth/death year removed from the subject labels. See #145.

@jschnasse
Copy link
Author

We were told that it looks kind of rude to present the birth date of all ladies and gentlemen to everyone. We chose to present it only to the library staff (useful for individualisation) but not to the end user. Thank you for solving this!

@acka47 acka47 added the working label Oct 14, 2015
@dr0i
Copy link
Member

dr0i commented Oct 15, 2015

Cheez. Note: we assume that rudeness is kinda relative:
if you would be a subject of something (and not a contributor or creator), we leave the Lebensdaten in the data, see e.g. http://lobid.org/resource/HT015891797. Same goes true for subject chains.

@dr0i dr0i changed the title Remove birthDate from preferredName Remove birthDate from creator and contributor. Oct 15, 2015
dr0i added a commit to lobid/lodmill that referenced this issue Oct 15, 2015
Don't remove this data from persons as subjects, though.

See hbz/lobid#244.

- adjust tests
@dr0i dr0i added review and removed working labels Oct 15, 2015
@dr0i
Copy link
Member

dr0i commented Oct 16, 2015

Deployed to staging.

@dr0i dr0i assigned acka47 and jschnasse and unassigned dr0i and acka47 Oct 16, 2015
@acka47
Copy link
Contributor

acka47 commented Oct 16, 2015

+1

@acka47 acka47 added deploy and removed review labels Oct 16, 2015
@jschnasse
Copy link
Author

+1

@dr0i
Copy link
Member

dr0i commented Oct 16, 2015

Deployed to production, closing.

@dr0i
Copy link
Member

dr0i commented Oct 28, 2015

We were told that it looks kind of rude to present the birth date of all ladies and gentlemen to everyone

This should have give me the hint - it's about presenting , not so much about the underlying data. This should be an issue of the frontend, especially when considering the ridiculously amount of work and implementation of logik when doing e.g. lobid/lodmill#742.
This is not KIS.

@jschnasse
Copy link
Author

I think it is better to not include birth dates into 'preferredName'. I think also that it was a mistake to do so in first run. There are potentially many front ends but only one lobid. One work hour at lobid saves n*work hours at the clients.

@dr0i
Copy link
Member

dr0i commented Oct 28, 2015

Maybe , maybe not. E.g. you may miss birth dates when facetting. Point is, the data is in part concatenated , see e.g. lobid/lodmill#742, doing frontends job. Would be better to have multiple fields (like you said at the beginning of the ticket) and let the frontends doing whatever they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants