replace standard maven properties imported from surefire #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surefire argLine parsing now controlled by a flag to allow easy disable if it causes problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last release pitest was updated to read argLine arguments from the surefire config, including support for surefire's late parsing of fields using the '@' symbol.
Unfortunately standard fields using the maven '$' syntax were being brought through unreplaced when read from surefire, causing errors when launching processes.
This change resolves this issues, and also moves the parsing of surefire arglines under the control of a new
parseSurefireArgLineparameter. This is enabled by default, but can be set to false if attempting to read the surefire argline causes an issue for a particular project.