Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -no_pie for darwin builds #141

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Use -no_pie for darwin builds #141

merged 2 commits into from
Feb 1, 2023

Conversation

rachitnigam
Copy link
Contributor

Fixes #140

@rachitnigam
Copy link
Contributor Author

CC @QuantamHD

@QuantamHD
Copy link
Collaborator

/gcbrun

@QuantamHD
Copy link
Collaborator

Does this fix the XLS build problem?

@rachitnigam
Copy link
Contributor Author

I'm trying it out on the XLS codebase using a bazel patch. Will update!

@rachitnigam
Copy link
Contributor Author

Sorry to poke you again @QuantamHD, just added the -Wl in front of the flags. Can you fire off the CI again?

@QuantamHD
Copy link
Collaborator

/gcbrun

@rachitnigam
Copy link
Contributor Author

This seems to fix the XLS failure as well!

@rachitnigam rachitnigam mentioned this pull request Feb 1, 2023
Closed
@rachitnigam
Copy link
Contributor Author

@QuantamHD I think this is good to merge! I can ping the XLS folks to change their SHA-commit dependency once this is merged

@QuantamHD QuantamHD merged commit 0b80df9 into hdl:main Feb 1, 2023
@QuantamHD
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure on Mac OS due to ld -no-pie
2 participants
@rachitnigam @QuantamHD