support windows spawn functions #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey headius any chance of getting this committeed and a new version pushed to rubygems.org? we're relying on spoon and would like it to work on jruby+windows cheers |
|
Oh wow, sorry that I missed this one. I'll have a look now. |
|
Ok! I have merged in your changes and made one addition that must have happened after your PR: errno checking. Have a look at master and let me know that I've merged things properly and that errno is working, and we can look at getting a release out. Sorry again for the delay! Feel free to email me directly in the future if you don't see action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posix_spawn doesn't exist on windows so i just reimplemented the same spawn capability using whatever functions i could find on msdn/the internet. i seems to work perfectly and returns the correct child pid, but i'm no expert