frontend: Abstract AppLogo with plugins' logic into its own component #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquimrocha
force-pushed
the
abstract-app-logo
branch
from
10422f0
to
bdd66e0
Compare
joaquimrocha
force-pushed
the
abstract-app-logo
branch
from
bdd66e0
to
e444526
Compare
illume
approved these changes
Jun 1, 2023
joaquimrocha
force-pushed
the
abstract-app-logo
branch
2 times, most recently
from
979f486
to
5fabc9a
Compare
The AppLogo logic was being used as a very simple component just displaying the original logo and thus was used in two different places with the logic for checking for a plugin overridden logo and error boundary, etc. These changes abstract all that into a component that can just be added anywhere that it's needed. The file is also moved from Sidebar/AppLogo to App/AppLogo, as it's a more logical place for this component (the component is also in the chooser, not just in the sidebar).
joaquimrocha
force-pushed
the
abstract-app-logo
branch
from
5fabc9a
to
a7cb33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AppLogo logic was being used as a very simple component just
displaying the original logo and thus was used in two different places
with the logic for checking for a plugin overridden logo and error
boundary, etc.
These changes abstract all that into a component that can just be
added anywhere that it's needed.
The file is also moved from Sidebar/AppLogo to App/AppLogo, as it's a
more logical place for this component (the component is also in the
chooser, not just in the sidebar).
(This abstraction will be useful for when we implement the new design where the logo may be moved elsewhere)
How to test:
change-logoexample plugin