-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
photon: change base image to debian:bullseye-slim #10
Conversation
Ideally the image would be reworked/split into two to decouple the data processing from the build step and not include the data in the actual image as brought up in #4 but figured this can be done first regardless |
A few friends have convinced me that this is the way to go, so 100% agreed. What do you think of the graphhopper build config I wrote this morning? It's more complex for sure, but it does keep the data out of the image. Also just want to make sure you see #9 so you can avoid putting too effort into prettying it up, but I'll probably use a similar workflow for OTP. I'm considering cutting out one of the intermediate copies though? It just seems overly complicated right now: But I like having the on-disk artifact because it makes it really easy to have the Makefile work incrementally. |
Overall it's a step in the right direction I think!
You mean on the host filesystem outside of volumes? Agreed it makes things easier to work with. What do you think about mounting the docker volumes directly to paths on the local filesystem, rather than using native Compared to now I imagine something like this:
|
I love this idea in theory (it's actually what I started with!) but I think it would require us to parameterize the docker images with the users UID and GID to prevent files being created in your home directory that you don't own. Is there a clean way to do that? |
Also this PR looks good to me! Just tested it. We can continue this discussion here or in the discussions tab? |
Yes, and that's something that is desirable either way (operators may want to use separate per-container uids with minimal permissions for security reasons, for example) It may be that the only thing necessary is to tell docker to use the appropriate user ( In some cases one may need to add the user inside the container and maybe set some permissions in an init script - but from what I saw so far (actually have no experience with any of the containerized software before) I don't think it should be the case here. |
In order to use common base image. Note that tzdata is already installed in the new base image.
PHOTON_VERSION
andPHOTON_HASH