Edit POI details on OSM #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/edit-poi
branch
from
5e0aa2a
to
e55c167
Compare
This isn't optimal from a UX standpoint, but now that we're showing more POI information, this is a first step at letting Headway users update it.
michaelkirk
force-pushed
the
mkirk/edit-poi
branch
from
e55c167
to
f47c161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a button to "edit" the POI details. This is a followup to #268, which added the display of website and phone numbers for OSM venues. Now you can edit those details via a link to the OSM ID editor:
edit_osm.mov.mp4
There are a lot of problems with this approach.
The user needs to kind of understand what OSM is (or be willing to learn). Bouncing the user to a separate map app with a lot of other data not related to the POI stuff they wanted to edit isn't great. Or maybe the fields won't even be displayed. OTOH, OSM is a powerful editor if they know what they're doing and want to edit other things.
The user needs to have an OSM account (or be willing to create one). If they aren't already logged in to OSM, the "Edit on OSM" button will take the user to a "log in" page on OSM which isn't great. Provided they log in directly from there, they should then be redirected to the node they were trying to edit, which is nice.
The user won't see their changes reflected until the next import, which in the case of maps.earth could be upwards of a month or more.
But glaring problems aside, I see this as incremental progress. If anyone ever even tries to use this editing flow, I might be inspired to put more effort into something more sophisticated.