Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page navigation in the page editing interface #357

Closed
reusr1 opened this issue Apr 2, 2020 · 14 comments
Closed

page navigation in the page editing interface #357

reusr1 opened this issue Apr 2, 2020 · 14 comments
Assignees
Labels
HIGH! high priority UX/UI User Interface

Comments

@reusr1
Copy link
Contributor

reusr1 commented Apr 2, 2020

when editing a page we currently have to leave the editor and come back to the editor if we want to edit another page. We should add a page navigation element at the top right of the editor

image

the dropdown should allow us to browse the page hierarchy of the site as a tree and allow for adding pages

@reusr1 reusr1 added the UX/UI User Interface label Apr 2, 2020
This was referenced Apr 2, 2020
@flx-sta flx-sta added the HIGH! high priority label Apr 3, 2020
flx-sta pushed a commit that referenced this issue Apr 8, 2020
@flx-sta
Copy link
Contributor

flx-sta commented Apr 8, 2020

@reusr1 as we agreed: you start off with this issue

@reusr1 reusr1 removed their assignment Apr 9, 2020
flx-sta pushed a commit that referenced this issue Apr 16, 2020
flx-sta pushed a commit that referenced this issue Apr 16, 2020
flx-sta pushed a commit that referenced this issue Apr 16, 2020
flx-sta pushed a commit that referenced this issue Apr 16, 2020
flx-sta pushed a commit that referenced this issue Apr 17, 2020
flx-sta pushed a commit that referenced this issue Apr 17, 2020
flx-sta pushed a commit that referenced this issue Apr 17, 2020
@reusr1 reusr1 assigned flx-sta and unassigned reusr1 Apr 20, 2020
@flx-sta
Copy link
Contributor

flx-sta commented Apr 21, 2020

Jup...

@flx-sta
Copy link
Contributor

flx-sta commented Apr 21, 2020

@reusr1 now supports templates.
please validate

@reusr1
Copy link
Contributor Author

reusr1 commented Apr 23, 2020

@Felix-Puetz we need to filter out any nodes that do not have the resourceType set to per:Page as otherwise we confuse the user (for example navigating to the robots.txt file does not work in this case). I'd suggest we should add an array of allowed node types to the nodetreeitem component and filter against that list

@reusr1 reusr1 removed their assignment Apr 23, 2020
@flx-sta
Copy link
Contributor

flx-sta commented Apr 23, 2020

was a bit quick there

BUT NOW fixed

@reusr1
Copy link
Contributor Author

reusr1 commented Apr 23, 2020

@Felix-Puetz please add the list to filter by as a prop to the nodetreeitem - we should also not use v-if for this but change the list to a computed property with a filter - apparently that's better for performance in vue :-)

@reusr1 reusr1 removed their assignment Apr 23, 2020
@flx-sta
Copy link
Contributor

flx-sta commented Apr 23, 2020

@reusr1 pre-filtering is now active

and new issue has been created for the edge-case of having hasChildren = true but no per:Page children presen (#377)

@flx-sta
Copy link
Contributor

flx-sta commented May 5, 2020

@reusr1 any new info about validation?

@reusr1
Copy link
Contributor Author

reusr1 commented May 5, 2020

closing this issue as it works as spec'd

@reusr1 reusr1 closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HIGH! high priority UX/UI User Interface
Projects
None yet
Development

No branches or pull requests

2 participants