Added option to pass OTP length #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…length Added option to pass OTP length
|
@shivanibhanwal looks good 😁 , I'd like to see the tests |
|
@shivanibhanwal any progress on this? |
|
Sorry really going busy but will do it 😄 |
…it will be default length for the otp_code Fixed existing test as it was not checking for the expected scenarios
|
Hello @robertomiranda Thanks |
|
@shivanibhanwal yay! thanks 👍 , I'll check it tonight |
robertomiranda
added a commit
that referenced
this pull request
Oct 10, 2014
…_length Added option to pass OTP length
|
@shivanibhanwal great job, thanks 👍 |
robertomiranda
added a commit
that referenced
this pull request
Oct 10, 2014
|
Thank you @robertomiranda for merging it!! Glad i could contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12