Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__hash__ is not inherited from parent class when __eq__ is overridden, define new __hash__ to account for this #37

Merged
merged 3 commits into from
Feb 14, 2016

Conversation

tulioz
Copy link
Contributor

@tulioz tulioz commented Feb 14, 2016

No description provided.

@tulioz
Copy link
Contributor Author

tulioz commented Feb 14, 2016

Forgot to mention, this is due to a change in Python 3. Previously the revere was necessary and subclasses had to explicitly set __hash__ = None to let the interpreter know that they were no longer hashable.

@dhui
Copy link
Contributor

dhui commented Feb 14, 2016

:shipit:

adepue pushed a commit that referenced this pull request Feb 14, 2016
__hash__ is not inherited from parent class when __eq__ is overridden, define new __hash__ to account for this
@adepue adepue merged commit 4e1ae04 into hearsaycorp:master Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants