Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to *ring* 0.9.4. #13

Merged
merged 1 commit into from
May 9, 2017
Merged

Update to *ring* 0.9.4. #13

merged 1 commit into from
May 9, 2017

Conversation

briansmith
Copy link
Contributor

Before ring 0.9.3, it was possible to link multiple versions of ring into a program, e.g. if one version depended on ring 0.6 and another dependend on ring 0.9. Unfortunately, this doesn't work, because the linker doesn't know to how to link ring's C/asm code correctly in that kind of situation. ring 0.9.3 added a flag to its Cargo.toml to tell the Rust toolchain to stop allowing multiple versions of ring to be linked into the same program, to prevent any problems this may cause.

ring 0.9.4 was released with an update to make some crates easier to update to 0.9.x.

Note that this requires cookie-rs 0.8.0 to be released, because the previous version of cookie-rs depended on ring 0.7.6, which would cause exactly the kind of multi-linking problem that this is trying to (in the end) prevent. See rwf2/cookie-rs#89.

@heartsucker
Copy link
Owner

heartsucker commented May 9, 2017

Blocked by rwf2/cookie-rs#90
Edit: unblocked

@heartsucker
Copy link
Owner

heartsucker commented May 9, 2017

@briansmith I think you are missing SecureRandom from some of the imports here.
Edit: Just kidding, unrelated Travis errors.

@heartsucker
Copy link
Owner

Merging in light of Travis errors since cookie = 0.8.0 is definitely out and alive. Not sure why the beta and nightly channels can't find it. I'm attributing this to strange Travis container caching.

@heartsucker heartsucker merged commit 1c1db1b into heartsucker:develop May 9, 2017
@briansmith
Copy link
Contributor Author

Could you publish a new version on crates.io? Thanks!

@heartsucker
Copy link
Owner

@briansmith I've been getting this error on rust-csrf that I need to resolve before I can release this. I'm going to open an issue there to remind myself to fix it.

heartsucker@pythagoras:~/code/heartsucker/rust-csrf (develop)$ c test
    Updating registry `https://github.com/rust-lang/crates.io-index`
error: failed to select a version for `lazy_static` (required by `ring`):
all possible versions conflict with previously selected versions of `lazy_static`
  version 0.2.2 in use by lazy_static v0.2.2
  possible versions to select: 0.2.8, 0.2.7, 0.2.6

@heartsucker
Copy link
Owner

@briansmith Published

@briansmith
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants