Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8-comprehensions to 3.4.0 #65

Merged

Conversation

pyup-bot
Copy link
Collaborator

This PR updates flake8-comprehensions from 3.3.1 to 3.4.0.

Changelog

3.4.0

------------------

* Remove rules C407 (Unnecessary ``<dict/list>`` comprehension - ``<builtin>``
can take a generator) and C412 (Unnecessary ``<dict/list/set>`` comprehension
- 'in' can take a generator). Both rules recommended increasing laziness,
which is not always desirable and can lead to subtle bugs. Also, a fully
exhausted generator is slower than an equivalent comprehension, so the advice
did not always improve performance.

Thanks to David Smith, Dylan Young, and Leonidas Loucas for the report in
`Issue 247
<https://github.com/adamchainz/flake8-comprehensions/issues/247>`__.
Links

@heavenshell heavenshell merged commit 4adbbb0 into master Mar 19, 2021
@heavenshell heavenshell deleted the pyup-update-flake8-comprehensions-3.3.1-to-3.4.0 branch March 19, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants