-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localized dates cause crash with load_table_columnar method #219
Comments
Can you provide a reproducible example? Even a printed example of what the |
Thanks @randyzwitch -- I'll get this replicated and upload some code to show the issue. |
@randyzwitch Just added a bit more detail, I'm not sure if this is expected behavior or not since the columns in OmniSci are |
We should think through what the desired behavior is here. In your example, you are converting to UTC to get a |
`np.dtype('datetime64[ns, UTC]')` is not a numpy type. Therefore, we were getting the type error. I have also added a proper conversion of of timestamps from various Timezones to 'UTC'. Since that is a standard which we follow in core. Also added unit tests to validate and catch similar exception in future. With new changes: 1) TIMESTAMP type with different timezones would be accepted and converted to GMT/UTC time which is assumed/followed in omnisci core 2) Increase unit tests coverage Relates to #219 fixes #253
`np.dtype('datetime64[ns, UTC]')` is not a numpy type. Therefore, we were getting the type error. I have also added a proper conversion of of timestamps from various Timezones to 'UTC'. Since that is a standard which we follow in core. Also added unit tests to validate and catch similar exception in future. With new changes: 1) TIMESTAMP type with different timezones would be accepted and converted to GMT/UTC time which is assumed/followed in omnisci core 2) Increase unit tests coverage Relates to #219 fixes #253
`np.dtype('datetime64[ns, UTC]')` is not a numpy type. Therefore, we were getting the type error. I have also added a proper conversion of of timestamps from various Timezones to 'UTC'. Since that is a standard which we follow in core. Also added unit tests to validate and catch similar exception in future. With new changes: 1) TIMESTAMP type with different timezones would be accepted and converted to GMT/UTC time which is assumed/followed in omnisci core 2) Increase unit tests coverage Relates to #219 fixes #253
While attempting to load a table into OmniSci via pymapd's columnar load with
con.load_table_columnar(mapdtable, df, preserve_index=False, col_names_from_schema=True)
I receive back:
This is from latest master release
pymapd==0.10.1.dev11+ga3fd5b9
Replication
Create a table with a single column as type
TIMESTAMP(0)
:create table example(test TIMESTAMP(0))
Run the following python code:
The text was updated successfully, but these errors were encountered: