Add support for pyarrow 0.11 and python3.7, remove python 3.4 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of how conda works, having python versions keeps causing conda to change python versions
2 tasks
|
This PR also supersedes #95 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR is to allow for pymapd users to use pyarrow 0.11 and/or python 3.7 if they choose. Based on hard requirements of pymapd, this PR shows that choosing either or both is feasible.
Implementation specifies lower bound for pyarrow at 0.10 (current bound), but sets upper bound at <0.12 (just in case 0.12 changes binary compatibility). The only gotcha here is that if users choose to install cudf, pyarrow will need to downgrade to pyarrow 0.10 (unless cudf begins supporting pyarrow 0.11).
During the course of this PR, found that CI wasn't exactly working correctly, so fixed that as well. This highlighted that our dependency stack doesn't support Python 3.4, so it was removed.