Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for legacy Python 2 #155

Merged
merged 7 commits into from
Jan 21, 2019
Merged

Drop support for legacy Python 2 #155

merged 7 commits into from
Jan 21, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 19, 2019

Fixes #131.

@hugovk hugovk mentioned this pull request Jan 19, 2019
Closed
@randyzwitch
Copy link
Contributor

Thanks! I’ll review this Monday when I’m back at work

randyzwitch
randyzwitch suggested changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@randyzwitch randyzwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, the PR looks pretty thorough. After removing the mapd file changes, this should be okay to merge

mapd/MapD-remote Outdated Show resolved Hide resolved
mapd/MapD.py Outdated Show resolved Hide resolved
mapd/ttypes.py Outdated Show resolved Hide resolved
@randyzwitch randyzwitch merged commit d3cacad into heavyai:master Jan 21, 2019
@hugovk hugovk deleted the rm-2 branch January 21, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyzwitch randyzwitch randyzwitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @randyzwitch