Swap itertuples for .values #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling .values on a dataframe creates an array, promoted to the common datatype able to hold all the data. This can cause ints to be converted to float and other undesirable behavior. Intent is just to move from dataframe to an iterable, which itertuples does, without changing data representation in a cell
randyzwitch
added a commit
that referenced
this pull request
Apr 11, 2019
Fixes #209 Calling .values on a dataframe creates an array, promoted to the common datatype able to hold all the data. This can cause ints to be converted to float and other undesirable behavior. Intent is just to move from dataframe to an iterable, which itertuples does, without changing data representation in a cell Add integer CPU tests Test table structure Switch from testing ints to no nulls Add integer CPU tests Test table structure Switch from testing ints to no nulls Add integer CPU tests Test table structure Switch from testing ints to no nulls Add integer CPU tests Test table structure Switch from testing ints to no nulls Add integer CPU tests Test table structure Switch from testing ints to no nulls Add integer CPU tests Test table structure Switch from testing ints to no nulls Add integer CPU tests Test table structure Switch from testing ints to no nulls Add integer CPU tests Add integer CPU tests Test table structure Switch from testing ints to no nulls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling .values on a dataframe creates an array, promoted to the common datatype able to hold all the data. This can cause ints to be converted to float and other undesirable behavior.
Intent is just to move from dataframe to an iterable, which itertuples does without changing data representation in a cell