Added type to options object #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option object now supports a type key/value, the application will throw an error when an unsupported type is requested. See qrencode -help for supported types.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "qr", | |||
| "description": "A small library to generate QR codes with libqrencode.", | |||
| "version": "0.2.0", | |||
| "version": "0.2.1", | |||
There was a problem hiding this comment.
it's best practice to not change this in pull requests, and let the maintainer update this
There was a problem hiding this comment.
Cool, I'll revert that change
As per https://github.com/freewil suggestion if no type option is passed the -t flag and parameter will not be passed to qrencode process
|
@freewil thanks for reviewing my changes so quickly! |
|
|
||
|
|
||
| // Remove type if the option has not been passed | ||
| if(self.types.indexOf(cmd_options.type) === -1){ |
There was a problem hiding this comment.
should probably make this cmd_options.type.toUpperCase() so the user can pass in 'svg', etc.
Tests for changes to the default object, tests that a toUpperCase string exists in the allowed types.
|
Thanks guys -- republished as v2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option object now supports a type key/value, the application will throw an error when an unsupported type is requested.
See qrencode -help for supported types.