-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sunrise/sunset changes by large amount between February and March #22
Comments
Thanks. We will do some investigation. We are using the solar-calc JavaScript library, and you have provided helpful guidance. |
Started taking a closer look into the solar-calc library and I think this issue is arising from a bug in how it calculates the Julian date. Here are some examples from Dec 31 2020 to Mar 2 2021.
When you compare these dates to the dates provided by an online conversion tool such as https://www.onlineconversion.com/julian_date.htm you can see that everything from Jan 1 to Feb 28 is incorrect. |
Agreed - the problem was indeed exactly as you describe. I've implemented a fix and have published new npm package |
Changes deployed. https://www.hebcal.com/zmanim?cfg=json&start=2021-02-27&end=2021-03-02&geo=zip&zip=07666 Closing this bug. Some URLs may be cached for up to 30 days so if you find something that looks wrong, check the |
Created an issue on the wrong project, so reposting here.
Original ticket: hebcal/hebcal#213
The text was updated successfully, but these errors were encountered: