test: added a sanity test for the package #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I was young and stupid when i did this originally and, now am a little older and less stupid. Adding Jest is fine. I can either merge this as is, or let you redo it and merge later. In the future, when you make a pull request, it's best to do from a branch on your fork and not master. |
sagi053
approved these changes
Sep 20, 2019
|
I plan on adding Jest in two weeks. |
Closed
|
Closing in favor of #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a very simple sanity test file to verify a few of the documented API methods.
I would prefer to rewrite it using Jest as the test runner, but I didn't want to introduce any new dependencies.
If you are open to adding Jest as a dev dependency, please let me know and it'll improve the tests dramatically.