Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window messages aren't sorted, resulting in errors when a window is only active for a single frame #40

Open
hybridherbst opened this issue Oct 7, 2021 · 1 comment

Comments

@hybridherbst
Copy link
Contributor

When using screenshot tools like ShareX, there's weird window stuff happening: a temporary screenshot window appears for a single frame and is removed again immediately.

This seems to cause issues with the UwcManager and the window messages – sometimes the "added" messages appear after the "removed" messages, and sometimes there is no "removed" message at all.

Here's a screenshot with the events being logged - the first number is the frame index:
image

To reproduce:

  • in UwcWindowList.cs, add "listItem.Enable();" as last line in OnWindowAdded to add every found window automatically
  • download and install https://getsharex.com/
  • make a screenshot with ShareX while Uwc is running
  • note you'll get a broken white window (no texture)
hecomi added a commit that referenced this issue Oct 16, 2021
hecomi added a commit that referenced this issue Oct 16, 2021
@hecomi
Copy link
Owner

hecomi commented Oct 16, 2021

Thank you for the report.

This bug was not actually caused by the sort order, but by the management of list items. Specifically, in this sample, it was a simple bug that the window object in Unity did not disappear when the actual window was removed.

But as you pointed out, there was a potential bug related to the sort order, so I've fixed it as well. Could you please check it?

github-actions bot pushed a commit that referenced this issue Nov 6, 2021
github-actions bot pushed a commit that referenced this issue Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants