Depth testing support #13
Conversation
| stencil_back: wgpu::StencilStateFaceDescriptor::IGNORE, | ||
| stencil_read_mask: 0, | ||
| stencil_write_mask: 0, | ||
| }) |
There was a problem hiding this comment.
Should we allow this level of configuration or could we simply ask for the format and hardcode this internally?
There was a problem hiding this comment.
I actually like taking the entire DepthStencilStateDescriptor, because I'm actually using a difference comparison function. I can imagine that users might want to change other aspects of the depth stencil state as well.
| stencil_store_op: wgpu::StoreOp::Store, | ||
| clear_depth: -1.0, | ||
| clear_stencil: 0, | ||
| }, |
There was a problem hiding this comment.
Same question here. Could we simply ask for a TextureView (i.e. the depth_view) here?
There was a problem hiding this comment.
For me, I would also find it useful to pass in the whole RenderPassDepthStencilAttachmentDescriptor. In my case, I'm using a different value for clear_depth.
| stencil_back: wgpu::StencilStateFaceDescriptor::IGNORE, | ||
| stencil_read_mask: 0, | ||
| stencil_write_mask: 0, | ||
| }) |
There was a problem hiding this comment.
I actually like taking the entire DepthStencilStateDescriptor, because I'm actually using a difference comparison function. I can imagine that users might want to change other aspects of the depth stencil state as well.
| stencil_store_op: wgpu::StoreOp::Store, | ||
| clear_depth: -1.0, | ||
| clear_stencil: 0, | ||
| }, |
There was a problem hiding this comment.
For me, I would also find it useful to pass in the whole RenderPassDepthStencilAttachmentDescriptor. In my case, I'm using a different value for clear_depth.
|
I was able to successfully use this in my own project 👍 |
|
Glad to know! I will keep the API as it is then! We may be able to improve it in the future once/if we see a pattern. |
hecrj
force-pushed
the
feature/depth-testing
branch
from
38cf8d6
to
0eda122
Compare
|
Another note on customizing my own rendering, in case it's helpful: I needed to change the "load op" values from |
Fixes #11.