Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foh holybolt #291

Merged
merged 5 commits into from
Jun 9, 2024
Merged

Foh holybolt #291

merged 5 commits into from
Jun 9, 2024

Conversation

SoundsLegit
Copy link
Contributor

Added usage of holy bolt in between (approximate) cooldowns of fist of the heavens when fighting a demon-type boss (Mephisto, Andariel, Duriel, Diablo, Baal)

@AquaRush
Copy link
Contributor

AquaRush commented Jun 7, 2024

Hi, it would be best to modify the script to work only with all the super bosses except Andariel.
Andariel area is filled with unique monsters sometimes, where FoH works well on cleaning them, it creates a safer environment for HC players :)
Thanks for the contribution!

@SoundsLegit
Copy link
Contributor Author

Hi, it would be best to modify the script to work only with all the super bosses except Andariel. Andariel area is filled with unique monsters sometimes, where FoH works well on cleaning them, it creates a safer environment for HC players :) Thanks for the contribution!

The idea is not to just use holy bolt on demon bosses, but to switch to using holy bolt 3 times quickly while FoH is on cooldown and then switch back to FoH and use it again. The character will still use FoH on andariel. This is the best of both worlds.
Also, to deactivate this feature, it is enough to just not have the holy bolt/Foh mouse 1 hotkeys binded

@AquaRush
Copy link
Contributor

AquaRush commented Jun 7, 2024

Hi, it would be best to modify the script to work only with all the super bosses except Andariel. Andariel area is filled with unique monsters sometimes, where FoH works well on cleaning them, it creates a safer environment for HC players :) Thanks for the contribution!

The idea is not to just use holy bolt on demon bosses, but to switch to using holy bolt 3 times quickly while FoH is on cooldown and then switch back to FoH and use it again. The character will still use FoH on andariel. This is the best of both worlds. Also, to deactivate this feature, it is enough to just not have the holy bolt/Foh mouse 1 hotkeys binded

I see, that makes more sense then, thanks!

@SoundsLegit
Copy link
Contributor Author

With the latest commit I made it simpler.
Holy bolt can be set as a mouse button 2 key bind, and the bot only does 2 holy bolts before switching back to FoH.

Fixed the rare bug I saw when testing that the character could get stuck on using holy bolt for monsters instead of FoH, added a check to make sure this doesn't happen.
@SoundsLegit
Copy link
Contributor Author

SoundsLegit commented Jun 8, 2024

Ready for merge on last commit, fixed the bug of potentially not switching back to FoH for normal mobs.
If the bindings for mouse button 1 exist for holy bolt and FoH, the bot will alternate between them for bosses while maintaining conviction.

@TDLofCC
Copy link
Contributor

TDLofCC commented Jun 9, 2024

Been running this change on my FoH pala since it was made, seems to run very well.

@hectorgimenez hectorgimenez merged commit 67d27aa into hectorgimenez:main Jun 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants