Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reproduce's Psalm's ReturnTypeProviders #1

Closed
hectorj opened this issue Mar 30, 2020 · 0 comments · Fixed by #2
Closed

Reproduce's Psalm's ReturnTypeProviders #1

hectorj opened this issue Mar 30, 2020 · 0 comments · Fixed by #2
Assignees
@hectorj

Comments

@hectorj
Copy link
Owner

hectorj commented Mar 30, 2020

For example https://github.com/vimeo/psalm/blob/b46e1477359b4d99d4c39ffac53c4958524b4f89/src/Psalm/Internal/Provider/ReturnTypeProvider/StrReplaceReturnTypeProvider.php which I saw mentionned there: thecodingmachine/safe#124 (comment)

And there are plenty more: https://github.com/vimeo/psalm/tree/master/src/Psalm/Internal/Provider/ReturnTypeProvider
@hectorj hectorj self-assigned this Mar 30, 2020
hectorj added a commit that referenced this issue Mar 30, 2020
@hectorj
Adapt Vimeo's StrReplaceReturnTypeProvider to \Safe\preg_replace
181f1d1 
With 2 simple test cases:
- given an array as $subject, returns an array
- given as string as $subject, returns a string

Closes #1
hectorj added a commit that referenced this issue Mar 30, 2020
@hectorj
Adapt Vimeo's StrReplaceReturnTypeProvider to \Safe\preg_replace
5fd7aac 
With 2 simple test cases:
- given an array as $subject, returns an array
- given as string as $subject, returns a string

Closes #1
@hectorj hectorj mentioned this issue Mar 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorj hectorj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt Vimeo's StrReplaceReturnTypeProvider to \Safe\preg_replace hectorj/safe-php-psalm-plugin
1 participant
@hectorj