Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser #12

Merged
merged 4 commits into from
Oct 5, 2019
Merged

Fix parser #12

merged 4 commits into from
Oct 5, 2019

Conversation

hectron
Copy link
Owner

@hectron hectron commented Oct 5, 2019

Problem

  • Chrome was never installed in the Dockerfile.
  • The wait implementation would only check for the DOM to be ready. It never waited for the network to return a 200.
  • Some things that return objects can not be chained with .wait

@hectron hectron merged commit be5dfe9 into master Oct 5, 2019
@hectron hectron deleted the fix_parser branch October 5, 2019 20:54
@hectron hectron mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hectron