Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special processing for printing ResizeArray<_> in Property.forAll #323 #324

Merged
7 commits merged into from
Mar 24, 2021
Merged

Special processing for printing ResizeArray<_> in Property.forAll #323 #324

7 commits merged into from
Mar 24, 2021

Conversation

altxt
Copy link
Contributor

@altxt altxt commented Mar 2, 2021

Tried to fix #323

TysonMN
TysonMN requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@TysonMN TysonMN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also the first solution that came to my mind.

It would be interesting to see if there are any bug reports or feature requests against F# for this behavior.

src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
tests/Hedgehog.Tests/PropertyTests.fs Outdated Show resolved Hide resolved
tests/Hedgehog.Tests/PropertyTests.fs Outdated Show resolved Hide resolved
src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
TysonMN
TysonMN reviewed Mar 3, 2021
View reviewed changes
src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
TysonMN
TysonMN reviewed Mar 4, 2021
View reviewed changes
src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
TysonMN
TysonMN approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@TysonMN TysonMN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @altxt! I think this is ready to merge.

@altxt
Moved a helper function into the using function
7424e90 
Replaced extra parentheses with indentation in test
@ghost ghost added this to the 0.11.0 milestone Mar 24, 2021
@ghost ghost mentioned this pull request Mar 24, 2021
Open
@ghost
Copy link

ghost commented Mar 24, 2021

Thanks for contributing, @altxt!

@ghost ghost merged commit 47db0bb into hedgehogqa:master Mar 24, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TysonMN TysonMN TysonMN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

A way to render a list completely in the report?
2 participants
@altxt @TysonMN