Generalized formatting of generated values #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Sep 11, 2021
src/Hedgehog/Gen.fs
Outdated
| gen with Config = { gen.Config with Formatter = formatter } | ||
| } | ||
|
|
||
| let ofRandom (r : Random<Tree<'a>>) : Gen<'a> = { |
There was a problem hiding this comment.
As noted in #346, this needs to be traced carefully so we don't end up overriding the configuration.
ghost
changed the title
TysonMN
reviewed
Sep 12, 2021
ghost
mentioned this pull request
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR to get feedback early. This is to address #326.
I tried adding this at a
Propertylevel, but its type argument doesn't track the type being generated so it doesn't work there./cc @moodmosaic @TysonMN