Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient falseToFailure #437

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Jul 15, 2023

No description provided.

@TysonMN TysonMN mentioned this pull request Jul 15, 2023
@AlexeyRaga
Copy link

This is great as it now works as expected!

Copy link
Member

@dharmaturtle dharmaturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why does PropertyBuilder's Return still use Property.ofBool?

src/Hedgehog/Property.fs Outdated Show resolved Hide resolved
@TysonMN
Copy link
Member Author

TysonMN commented Jul 16, 2023

why does PropertyBuilder's Return still use Property.ofBool?

I think that is dead code.

This is particularly better because the terminal code only
executed once in efficient rechecking is preserved.
@TysonMN TysonMN merged commit f4a4b00 into hedgehogqa:master Jul 16, 2023
@TysonMN TysonMN deleted the efficient_falseToFailure branch July 16, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants