Make responders into GenServers #55
Conversation
| end | ||
| def dispatch(msg, responders) do | ||
| Enum.map(responders, fn {_, pid, _, _} -> | ||
| :ok = GenServer.cast(pid, {:dispatch, msg}) |
There was a problem hiding this comment.
any reason not to just drop these pattern matches on cast? It can't ever return anything else so it doesn't really serve the 'fail fast' purpose at all with cast...
| case dispatch_responder(responder, msg, state) do | ||
| :ok -> | ||
| state | ||
| {:ok, state} -> |
There was a problem hiding this comment.
maybe new_state so this is a bit more clear? That's the elm coming out in me...
| @doc false | ||
| def usage(name) do | ||
| @usage | ||
| |> Enum.map(&String.strip/1) |
There was a problem hiding this comment.
I want first-class function composition in Elixir for these situations :)
There was a problem hiding this comment.
What about &(String.strip(&1) |> String.replace("hedwig", name))...or even:
def usage(name) do
import String
@usage
|> Enum.map(&(strip(&1) |> replace("hedwig", name))Or is this worse? :)
There was a problem hiding this comment.
(I never knew how much I wanted automatic currying til i had it)
| {aka, opts} = Keyword.pop(opts, :aka) | ||
| {name, opts} = Keyword.pop(opts, :name) | ||
| responders = Keyword.get(opts, :responders, []) | ||
| opts = robot.config(opts) |
There was a problem hiding this comment.
ever considered with here? I'm obviously bikeshedding
| _ -> | ||
| {:noreply, state} | ||
| end | ||
| end |
There was a problem hiding this comment.
def handle_in(%Hedwig.Message{}=msg, state), do: {:dispatch, msg, state}
def handle_in(_, state), do: {:noreply, state}?
There was a problem hiding this comment.
Yeah, I do like this a bit better. Also...could add these to the Robot generator.
| {:noreply, state} | ||
| end | ||
| def handle_cast({:handle_in, msg}, %{responder_sup: sup} = state) do | ||
| case __MODULE__.handle_in(msg, state) do |
There was a problem hiding this comment.
any reason you can't omit __MODULE__ here?
This change makes responders into isolated
GenServers allowing responders to maintain/update state.TODO