Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Allow equal sign in equality checks in Lezer parsers #5175

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Feb 24, 2024

While working on #5167 I realized we weren't parsing some examples properly, which let me to realize that I didn't include the equal sign in comparisons for levels 6 through 11.

How to test

I added some tests that should pass!

Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The only thing is that I think the code for printing the Lezer tree is accidentally committed.

static/js/cm-editor.ts Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Feb 27, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8504f39 into main Feb 27, 2024
11 checks passed
@mergify mergify bot deleted the fix_equality_check branch February 27, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants