Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Class overview redesign #5610

Merged
merged 33 commits into from
Jun 19, 2024
Merged

💻 Class overview redesign #5610

merged 33 commits into from
Jun 19, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Jun 12, 2024

This PR introduces a new redesign for the Class Overview page, by merging it together with the 'Live Statistics' and 'Overview of programs per adventure' pages. This simplifies the UI a lot, by not confusing users having to navigate through different and uneven UI elements. In this image we can see the new UI:

image

In the image we can distinguish 3 different sections:

  1. First the teacher is greeted with a table where they can check and verify the students saved programs. Here they can also perform several actions: change the password, delete the student from the class and also see their programs.
  2. Then, teachers can see a graph representing the engagement of the students with the contents, measured trugh their numbers of adventures tried, with respect to their numbers of errors and successful runs.
  3. After this the interface is similar to the one before, showing teachers and invitations.

Fixes #5097
Fixes #5424

How to test

  • Go to the class overview page of a class, check it out.

I had to open a new PR for this, but @Annelein also helped a lot in the building of this feature! Thanks a lot 😄

@Annelein
Copy link
Collaborator

@jpelay does this also close #5047 ?

@jpelay
Copy link
Member Author

jpelay commented Jun 17, 2024

@jpelay does this also close #5047 ?

I didn't read all of the comments before. It removes the access to page from the teacher's view. And it also removes part of the code. But I think if I remove all of the files this PR will become crowded so I was planning to do that on another PR.

@Felienne Felienne self-assigned this Jun 18, 2024
Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new design!!!! (and hope this will not break anything....)

@jpelay
Copy link
Member Author

jpelay commented Jun 19, 2024

Love the new design!!!! (and hope this will not break anything....)

Thanks!!

Copy link
Contributor

mergify bot commented Jun 19, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Jun 19, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit abcfb10 into main Jun 19, 2024
12 checks passed
@mergify mergify bot deleted the class-overview-redesign branch June 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants