Prefetch options for etcd and Consul #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaziine
reviewed
Apr 19, 2018
| return func(b *Backend) { | ||
| b.prefetch = true | ||
| } | ||
| } |
There was a problem hiding this comment.
The code related to the Option type should be moved somewhere else. It seems to be duplicated from the consul package.
WDYT ?
There was a problem hiding this comment.
📖 A little copying is better than a little dependency.
Basically, moving the Option system out of the backends would mean:
- tight coupling between them
- having one backend struct shared between all the backends
- having to export the fields ex:
prefetch->Prefetch - having options that only make sense in one backend but not another, but being able to pass them anyway
- and so on
There was a problem hiding this comment.
I wasn't aware about this video. Thanks ❤️
yaziine
approved these changes
Apr 19, 2018
jhchabran
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prefetch option for etcd and Consul that makes them fetch the entire subtree, cache it and use the cache to serve the keys to Confita without additional network round trips.
Fixes #10