This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
consumer/handler: Migrate Handler and HandlerFunc from kafka-go #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There's no need for the struct, it just holds a function, that's just as valid a type to hang another function off of.
asdine
approved these changes
Oct 10, 2018
consumer/handler/func.go
Outdated
|
|
||
| // HandlerFunc wraps a HandleMessagFn in such a way that it complies | ||
| // with the Handler interface. | ||
| func HandlerFunc(fn HandleMessageFn) Handler { |
There was a problem hiding this comment.
🌷 You don't need that function actually, a cast does the same thing. You can rename HandleMessageFn to HandlerFunc and let the user cast his func to a HandlerFunc (cf https://golang.org/src/net/http/server.go?s=59707:59754#L1950)
consumer/handler/func_test.go
Outdated
|
|
||
| // HandleMessageFn can be used as a Handler | ||
| func TestHandleMessageFn(t *testing.T) { | ||
| calls := make([]bool, 0) |
There was a problem hiding this comment.
📖 Just in case, var calls []bool works (almost) the same way, append accepts a zero value.
There was a problem hiding this comment.
Ah.. now that I didn't know. Thanks.
yaziine
approved these changes
Oct 10, 2018
tealeg
added a commit
that referenced
this pull request
Nov 13, 2018
consumer/handler: Migrate Handler and HandlerFunc from kafka-go
tealeg
added a commit
that referenced
this pull request
Nov 13, 2018
consumer/handler: Migrate Handler and HandlerFunc from kafka-go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8
Handlerinterface from kafka-goHandlerFuncfrom kafka-gofuncHandlerstruct - we can just hang theHandleMessagefunction off of a defined type for the method signature instead (I call thisHandleMessageFn)