This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
handler: Migrate handlers collection #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaziine
reviewed
Oct 12, 2018
| i := 0 | ||
| count := len(h.handlers) | ||
| topics := make([]string, count) | ||
| for t := range h.handlers { |
There was a problem hiding this comment.
❓ Why not using the for i, t := range h.handlers... syntax?
There was a problem hiding this comment.
Because handlers is a map, if you use that syntax i will be a key and t will be its value.
There was a problem hiding this comment.
Oops, I thought it was a list. Sorry 🙊
yaziine
suggested changes
Oct 12, 2018
consumer/handler/collection.go
Outdated
| type Collection struct { | ||
| sync.RWMutex | ||
|
|
||
| logger *logrus.Entry |
There was a problem hiding this comment.
Good catch. Removed.
yaziine
approved these changes
Oct 12, 2018
tealeg
added a commit
that referenced
this pull request
Nov 13, 2018
handler: Migrate handlers collection
tealeg
added a commit
that referenced
this pull request
Nov 13, 2018
handler: Migrate handlers collection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #9
I have taken the following steps:
Handlersstruct from kafka-go