Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

use fastuuid for UUID generation #38

Merged
merged 1 commit into from
May 23, 2019
Merged

use fastuuid for UUID generation #38

merged 1 commit into from
May 23, 2019

Conversation

rogpeppe
Copy link
Contributor

This avoids the problematic dependency on satori/go.uuid.

This avoids the problematic dependency on satori/go.uuid.
Copy link
Contributor

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Working.

Note that when builing / testing outside $GOPATH you need to always give a path when running commands, go test -v ./... rather than go test -v, otherwise Go won't resolve internal references to github.com/heetch/felice.

Copy link

@yaziine yaziine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tealeg
Copy link
Contributor

tealeg commented May 21, 2019

+1 Working.

Note that when buildng / testing outside $GOPATH you need to always give a path when running commands, go test -v ./... rather than go test -v, otherwise Go won't resolve internal references to github.com/heetch/felice.

Nope.. that was just me being dumb. Please ignore ;-)

@rogpeppe rogpeppe merged commit bb88348 into master May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants