Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

message: Migrate message to felice from kafka-go #4

Merged
merged 12 commits into from
Oct 9, 2018

Conversation

tealeg
Copy link
Contributor

@tealeg tealeg commented Oct 8, 2018

This PR migrates the Message and Option types from kafka-go into a new sub-package of felice.

Additionally, it does the following;

  • set up dep dependency definitions
  • initiate a .gitignore file to avoid checking in the vendor directory
  • radically expand test coverage from the state of kafka-go

@tealeg tealeg requested review from asdine and yaziine October 8, 2018 14:35
@tealeg tealeg self-assigned this Oct 8, 2018
Copy link

@yaziine yaziine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@jhchabran
Copy link

radical expand test coverage from the state of kafka-go

❤️

Copy link
Contributor

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@tealeg tealeg merged commit 067cd5f into master Oct 9, 2018
@tealeg tealeg deleted the migrate-message-to-felice branch October 11, 2018 07:20
tealeg added a commit that referenced this pull request Nov 13, 2018
message: Migrate message to felice from kafka-go
tealeg added a commit that referenced this pull request Nov 13, 2018
message: Migrate message to felice from kafka-go
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants