Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Travis ci setup #7

Merged
merged 10 commits into from
Oct 10, 2018
Merged

Travis ci setup #7

merged 10 commits into from
Oct 10, 2018

Conversation

tealeg
Copy link
Contributor

@tealeg tealeg commented Oct 9, 2018

This PR adds a .travis.yml file, (and Felice is now setup as a project on travis-ci.org). I've added a build condition badge, but no other badges as yet.

I also snuck a logo in ;-)

@tealeg tealeg self-assigned this Oct 9, 2018
@tealeg tealeg requested review from asdine and yaziine October 9, 2018 09:42
@tealeg
Copy link
Contributor Author

tealeg commented Oct 9, 2018

Fixes #5

README.md Outdated
@@ -1,4 +1,6 @@
![](https://raw.githubusercontent.com/heetch/felice/travis-ci-setup/felice.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

.travis.yml Outdated
- linux

script:
- go test -v -race -cover -timeout=1m ./...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Shouldn't we use the same configuration as in Confita?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily the same but we should choose how many Go versions we want to support

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least > 1.10. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@tealeg tealeg changed the base branch from migrate-message-to-felice to master October 9, 2018 12:57
Copy link
Contributor

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ❤️

@tealeg tealeg merged commit 4abd5d6 into master Oct 10, 2018
@tealeg tealeg deleted the travis-ci-setup branch October 10, 2018 13:55
tealeg added a commit that referenced this pull request Nov 13, 2018
tealeg added a commit that referenced this pull request Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants