-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Fixes #5 |
README.md
Outdated
@@ -1,4 +1,6 @@ | |||
![](https://raw.githubusercontent.com/heetch/felice/travis-ci-setup/felice.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ ❤️ ❤️
.travis.yml
Outdated
- linux | ||
|
||
script: | ||
- go test -v -race -cover -timeout=1m ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Shouldn't we use the same configuration as in Confita?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily the same but we should choose how many Go versions we want to support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least > 1.10. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! ❤️
This PR adds a
.travis.yml
file, (and Felice is now setup as a project on travis-ci.org). I've added a build condition badge, but no other badges as yet.I also snuck a logo in ;-)