Obed/improvements v2 #145
Merged
Obed/improvements v2 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/heetch-eng/flamingo/9yw0paacc |
obedparla
force-pushed
the
obed/improvements-v2
branch
from
f97a9c9
to
c30d540
Compare
obedparla
force-pushed
the
obed/improvements-v2
branch
from
c30d540
to
52f58f7
Compare
tamarasaurus
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Looks good 👍 , I just have another small suggestion. When I was using the Popover component I saw that even if the component is not visible (like opacity:0) it still overlays any elements beneath it, blocking clicks. I don't know if you already fixed that but it would be good to fix before v2.
ugogo
suggested changes
Apr 27, 2020
Ahh, I didn't know this. I was thinking about changing how it animates. We can always fix it after V2 |
ugogo
approved these changes
Apr 28, 2020
obedparla
force-pushed
the
obed/improvements-v2
branch
from
bef93bb
to
c43b4a0
Compare
obedparla
added a commit
that referenced
this pull request
Apr 29, 2020
* Change `type` to `alertType` in Alert internally, prevents dom type * Downgrade babel-plugin-styled-components to `1.10.5`, new version broken * Update a few small things. * Lower data example for table, couldn't see both tables easily * Remove packages from lerna. Not needed * Update the readme a bit * Add Alert back * Update readme, change back version, improve variable name tableProps * IconButton: add ref, fix bug with hover color and iconColor proptype * Remove text-decoration on button for the case of `as='a'` * Add fontWeight, fontSize and lineHeight style props to UiText * Add id to Input and TextArea, removed them by error * Add back state classes to Selector component, only way to know state * Add custom props to Heading * Remove system fonts * Add visibility: hidden for popover to prevent it getting clicks
obedparla
added a commit
that referenced
this pull request
Apr 29, 2020
* Implement base components with Styled Components * Add iconSize to proptypes Spinner. Simplify style validation in UiText Delete deprecated folder, it's not up to date (#129) Obed/components migration (#132) * Migrate IconButton * Migrate IconButton * Migrate SidePanel * Migrate Text * Update Styled Components to v5.1.0 * Improve code for created components. Use `attrs` instead of extending * Add `index` with all components * Add babel-plugin-styled-components * Fix Button spinner not behaving the same as before * Remove displayName from SC components. Handled by SC * Remove usage of `cx` inside `attrs` as classes are automatically added Remove babel class proposal plugin Obed/components migration 2 (#135) * Modify SidePanel to animate on mount and unmount. - This makes it much easier to use in more situations, since it's the react way, instead of leaving the elements in the dom, which can cause unexpected consequences - It should also make it easier to animate when using it as a route * Migrate `Link` * Migratee TextArea * Migrate TextAreaField * Add `margin` and `color` as SC props to UiText. We use them a ton * Migrate UploaderItem * Migrate FileUploader * Migrate FileUploader * Migrate ImageUploaders * Remove dist from git * Move --f-FileUploader-height to root * Migrate ImageUploaderField * Migrate FileUploaderField * Disable import/prefer-default-export * Move sidepanel styles to a file * Fix review comment * Because clean code is more important than the Higgs boson Update now-build scripts Fix eslint errors Update now.json Upgrade deps Obed/components migration 3 (#139) * Modify SidePanel to animate on mount and unmount. - This makes it much easier to use in more situations, since it's the react way, instead of leaving the elements in the dom, which can cause unexpected consequences - It should also make it easier to animate when using it as a route * Migrate Item component * Fix Button, it wasn't passing `ref` before. Oops * Add margin-left for buttons next to each other. * Fix Sidepanel, forgot to pass animateOnMount. Remove button styles * Fix Overlay, it was always animating, now only when passing isOpen * Migrate Dropdown component. Extend the story book examples * Migrate Card component * Add searchPlus from master * Change UiText's color to textColor. `color` is a DOM attribute * Migrate Table component * Remove `TableHeaderGroup` and `TableRowGroup` - They didn't make any sense to me, they're a regular element with a class Obed/components migration 4 (#142) * Migrate Table component * Remove `TableHeaderGroup` and `TableRowGroup` - They didn't make any sense to me, they're a regular element with a class * Migrate Radio component * Update FormElement to extend a UiText as in V1. * Migrate Select and SelectField * Migrate Selector and SelectorField * Migrate Alert component * Fix proptype errors * Migrate Grid component * Migrate Toggle component * Migrate Checkbox component * Migrate Popover component * Migrate Tabs component * Add success and error states to the button * Fix differences between implementation and original components Wrap checkbox around FormElementWrapper. Move styles to file FileUploader: fix styling error on hover Fix error in GridCol, change file name. Fix transition of Radio Move form elements into Form story * Export all components through index.js, add GridCol * Add select option disabled. This was in `master` already * Remove unnecessary defaultProps. It takes precious kbs * Comments of review migration-3 (I'm lazy to fix rebase conflicts :( ) * Migrate Datepicker and fix a bug with FormElement's withIcon * Add validation to Checkbox and Radio and logic for Icon and Labels Add theme support (#144) * Migrate Table component * Remove `TableHeaderGroup` and `TableRowGroup` - They didn't make any sense to me, they're a regular element with a class * Migrate Grid component * Fix differences between implementation and original components Wrap checkbox around FormElementWrapper. Move styles to file FileUploader: fix styling error on hover Fix error in GridCol, change file name. Fix transition of Radio Move form elements into Form story * Create `theme` with all the css vars except breakpoints * Delete legacy classes * Update all css variables to use the js theme * Fix Dropdown overlay on mobile Obed/improvements v2 (#145) * Change `type` to `alertType` in Alert internally, prevents dom type * Downgrade babel-plugin-styled-components to `1.10.5`, new version broken * Update a few small things. * Lower data example for table, couldn't see both tables easily * Remove packages from lerna. Not needed * Update the readme a bit * Add Alert back * Update readme, change back version, improve variable name tableProps * IconButton: add ref, fix bug with hover color and iconColor proptype * Remove text-decoration on button for the case of `as='a'` * Add fontWeight, fontSize and lineHeight style props to UiText * Add id to Input and TextArea, removed them by error * Add back state classes to Selector component, only way to know state * Add custom props to Heading * Remove system fonts * Add visibility: hidden for popover to prevent it getting clicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements before finishing v2