V3/migrate heading #164
Merged
V3/migrate heading #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/heetch-eng/flamingo/5q1kos2hm |
keanan
approved these changes
May 27, 2020
keanan
reviewed
May 27, 2020
Comment on lines
+58
to
+59
| m: '1.4rem', | ||
| l: '1.5rem', |
There was a problem hiding this comment.
How come 1.4 for M and 1.5 for L - should it not be somewhere closer to the center like 1.25 for M?
There was a problem hiding this comment.
I followed the current values from styles.css
https://github.com/heetch/flamingo/blob/master/src/styles.css#L44-L47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
HeadingcomponentSince components won't come with vertical spacing anymore, I created a
StoryHeadingone.Most of the changes are related to this
If you want quick access to the refactored Heading component, you can click here: https://github.com/heetch/flamingo/pull/164/files#diff-851f5ae413bc8a9023d063b6c2976c2a
Breaking changes