Added support for FMI lightning data #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
May 23, 2019 19:39
|
Looks nice and goes well with the existing codebase, thank you so much! ..unfortunately date for 22th of May seems to be unavailable now and there are no thunderstorms active - need to wait the next :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option for displaying lightning strikes on the rain radar overlay. The lightning observations are fetched and cached in the same fashion as the rain radar data.
The new functionality may be tested by initializing the app with
export NODE_ENV='fixeddate' && npm startand clicking 'Näytä salamat' from the UI. This will display the thunderstorms that occured on 22.5.2019.The existing features were not changed much.
frames.jsonnow includes lightning locations, and radar timestamps were switched to default ISO standard to match with the lightning timestamps. The code complies with the conventions enforced by eslint.