Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Install as dependency broken in npm3 #16

Closed
heikomat opened this issue Dec 17, 2016 · 0 comments
Closed

🚧 Install as dependency broken in npm3 #16

heikomat opened this issue Dec 17, 2016 · 0 comments
Assignees
Labels

Comments

@heikomat
Copy link
Owner

heikomat commented Dec 17, 2016

When the project, that should get installed with minstall, is itself installed as dependency of another project using npm3, the installation fails. minstall thinks it was started outside the project root (because there is no node_modules folder in the project-folder) and thus aborts.

When minstall is called, it should be able to detect, that the project is beeing installed as dependency by checking if the second-to-last folder of process.cwd() is node_modules. If that is the case, it needs to not abort, but instead provide a proper node_modules-folder in the project-folder before starting the rest of the installation.

I'm working on this here: #15

@heikomat heikomat added the bug label Dec 17, 2016
@heikomat heikomat self-assigned this Dec 17, 2016
@heikomat heikomat changed the title Install as dependency broken in npm3 🚧 Install as dependency broken in npm3 Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant